Fix broken bench: add missing test_context field to WeakPoint literal#132
Merged
Conversation
benches/scan_bench.rs built a WeakPoint literal without the `test_context` field added to the struct in v2.5.5, which broke `cargo bench` (run by .github/workflows/e2e.yml) and any `cargo check --all-targets`. Add `test_context: None`. Verified with `cargo check --benches` (Finished, clean). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0196movYBRwNw8vkLRaaFoTu
🔍 Hypatia Security ScanFindings: 43 issues detected
View findings[
{
"reason": "Issue in scorecard-enforcer.yml",
"type": "scorecard_publish_with_run_step",
"file": "scorecard-enforcer.yml",
"action": "split_scorecard_publish_job",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "Issue in instant-sync.yml",
"type": "secret_action_without_presence_gate",
"file": "instant-sync.yml",
"action": "peter-evans/repository-dispatch",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "unwrap_or(0) with dangerous default (3 occurrences, CWE-754)",
"type": "unwrap_dangerous_default",
"file": "/home/runner/work/panic-attack/panic-attack/src/axial/mod.rs",
"action": "flag",
"rule_module": "code_safety",
"severity": "critical"
},
{
"reason": "unwrap_or(0) with dangerous default (1 occurrences, CWE-754)",
"type": "unwrap_dangerous_default",
"file": "/home/runner/work/panic-attack/panic-attack/src/ambush/mod.rs",
"action": "flag",
"rule_module": "code_safety",
"severity": "critical"
},
{
"reason": "unwrap_or(0) with dangerous default (1 occurrences, CWE-754)",
"type": "unwrap_dangerous_default",
"file": "/home/runner/work/panic-attack/panic-attack/src/attestation/evidence.rs",
"action": "flag",
"rule_module": "code_safety",
"severity": "critical"
},
{
"reason": "expect() in hot path (2 occurrences, CWE-754)",
"type": "expect_in_hot_path",
"file": "/home/runner/work/panic-attack/panic-attack/src/attestation/chain.rs",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "unsafe block -- requires SAFETY comment (1 occurrences, CWE-676)",
"type": "unsafe_block",
"file": "/home/runner/work/panic-attack/panic-attack/src/jit_context.rs",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "mem::transmute bypasses type safety with unchecked bit reinterpretation (12 occurrences, CWE-704)",
"type": "transmute",
"file": "/home/runner/work/panic-attack/panic-attack/src/jit_context.rs",
"action": "flag",
"rule_module": "code_safety",
"severity": "critical"
},
{
"reason": "unwrap_or(0) with dangerous default (3 occurrences, CWE-754)",
"type": "unwrap_dangerous_default",
"file": "/home/runner/work/panic-attack/panic-attack/src/kanren/strategy.rs",
"action": "flag",
"rule_module": "code_safety",
"severity": "critical"
},
{
"reason": "unwrap_or(0) with dangerous default (1 occurrences, CWE-754)",
"type": "unwrap_dangerous_default",
"file": "/home/runner/work/panic-attack/panic-attack/src/sweep_tracker/mod.rs",
"action": "flag",
"rule_module": "code_safety",
"severity": "critical"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
hyperpolymath
added a commit
that referenced
this pull request
Jun 21, 2026
…133) ## What Removes the legacy `.github/workflows/scorecard-enforcer.yml`. ## Why This repo runs the OpenSSF Scorecard scan **twice** on every push: - `scorecard.yml` — delegates to the shared `hyperpolymath/standards` scorecard **reusable** workflow (the modern, canonical path), and - `scorecard-enforcer.yml` — a legacy self-contained job that runs its **own** full Scorecard scan + SARIF upload again. The governance **Check Workflow Staleness** gate explicitly requires this (seen failing on #132): > Remove legacy scorecard-enforcer.yml … Deleting the enforcer leaves a single Scorecard scan (via the reusable workflow) and removes the redundant Actions run. ## Note (separate follow-up) The same staleness gate also asks to refresh the Hypatia + Scorecard reusable **pins** to the current `hyperpolymath/standards` SHA. That needs read access to `hyperpolymath/standards` (not in this session's scope), so it's left as a follow-up — the staleness check may stay red on those pin items until then. This PR addresses only the duplicate-scan removal. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_0196movYBRwNw8vkLRaaFoTu --- _Generated by [Claude Code](https://claude.ai/code/session_0196movYBRwNw8vkLRaaFoTu)_ Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cargo benchfails to compile (and so does anycargo check --all-targets):WeakPointgainedpub test_context: Option<TestContext>in v2.5.5(
src/types.rs:325), but theWeakPoint { … }literal in thebench_location_extractionbenchmark was never updated. This is a livebreak, not latent:
.github/workflows/e2e.ymlrunscargo bench.The library and binaries are unaffected — this was the only error.
Fix
Add
test_context: None,to the benchmark'sWeakPointinitializer.Verification
cargo check --benches→Finished(clean; only the two pre-existinglibrary warnings remain).
🤖 Generated with Claude Code
https://claude.ai/code/session_0196movYBRwNw8vkLRaaFoTu
Generated by Claude Code